Cabal < 1.12.0 doesn't know about '--enable/disable-executable-dynamic'
or '--enable/disable-library-coverage'.

This is a problem in general, if rare, but it shows up in the
nix-local-build branch more obviously since it always passes all flags,
including defaults (it does this because the defaults should be
determined by the current version, not the older version).

Make the basic dependencyGraph construction function give us just a
Vertex -> UnitId mapping, rather than a full Vertex -> pkg. Then in
InstallPlan we keep that Vertex -> UnitId mapping and add a helper
function that does the additional lookup to give us a Vertex -> pkg
mapping. It's clearer this way, especially in the case of lookup errors.

This is easier to understand now that the canonical data vs the cached
graph is clarified. We only store the main data, the cached info is
reconstructed on deserialisation.

This is to clarify the lazy caching strategy we use for the fields for
the Graph (forward and reverse deps, and associated mappings).
Reorder the fields, and mark non-lazy fields as strict. Make
construction go via a smart constructor that fills in the cached fields.

Useful for reporting dir/file names in user interface code, e.g. in
notices and error messages.

Required by later nix-local-build branch patches.

Required by later nix-local-build branch patches.

Add Binary instances for many types

So we can use them in binary cache files.

Also relax version constraints on binary to work with binary-0.5.*,
which requires that we expose Distribution.Compat.Binary from Cabal.

D.Compat.Binary provides the Gerics support that we need to be able to
derive instances when using binary-0.5. It's useful to be able to use
binary-0.5 since that's the version bundled with older ghc versions.

remove duplicate LANGUAGE DeriveFoldable, minor improvements

Fix space leak in ./Setup configure

redundant map after fold

See https://github.com/haskell/cabal/issues/3003#issuecomment-174492371

It uses 'build-type: Simple' now.

Fixes #3003.

Fix bug in solver independent goals.

Add some more backwards-compatibility functions, fixes #3068.

Missing parentheses caused the solver to skip preferring linked packages with
the use of --reorder-goals.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Also rename it to '--documentation'. Note that the shorthand still works.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Distinguish between component ID and unit ID.

Enable tests in setup-dev.sh

It seems there are no longer any spurious failures, so we
can enable tests in setup-dev.sh

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

GHC 8.0 is switching the state sponsored way to specify
linker names from -this-package-key to -this-unit-id, so
it behooves us to use the right one.  But it didn't make
much sense to pass ComponentIds to a flag named UnitId,
so I went ahead and finished a (planned) refactoring
to distinguish ComponentIds from UnitIds.

At the moment, there is NO difference between a ComponentId
and a UnitId; they are identical.  But semantically, a
component ID records what sources/flags we chose (giving us enough
information to typecheck a package), whereas a unit ID records
the component ID as well as how holes were instantiated
(giving us enough information to build it.)  MOST code
in the Cabal library wants unit IDs, but there are a few
places (macros and configuration) where we really do
want a component ID.

Some other refactorings that got caught up in here:

    - Changed the type of componentCompatPackageKey to String, reflecting the
      fact that it's not truly a UnitId or ComponentId.

    - Changed the behavior of CURRENT_PACKAGE_KEY to unconditionally
      give the compatibility package key, which is actually what you
      want if you're using it for the template Haskell trick.  I also
      added a CURRENT_COMPONENT_ID macro for the actual component ID,
      which is something that the Cabal test-suite will find useful.

    - Added the correct feature test for GHC 8.0 ("Uses unit IDs").

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>