[skip ci]

[skip-ci]

Roman Kashitcyn authored 6 years ago and Mikhail Glushenkov committed 6 years ago

We still enable deduplication for some options, e.g. list of modules
or list of paths to search for includes/libraries.

Fixes #4449.

Herbert Valerio Riedel authored 6 years ago and Mikhail Glushenkov committed 6 years ago

Previously,

    Dependency on unbuildable library from darcs
    In the stanza 'test-suite darcs-test'
    In the inplace package 'darcs-2.11.0'

With this patch,

    Dependency on unbuildable (i.e. 'buildable: False') library from darcs
    In the stanza 'test-suite darcs-test'
    In the inplace package 'darcs-2.11.0'

We still have Hugs and other ancient stuff in there, so we should
either remove those as well, or keep LHC and JHC.

Alexander Vershilov authored 6 years ago and Mikhail Glushenkov committed 6 years ago

Do not ignore `install-includes stanza in the foreign-library.
And install headers.

kristenk authored 6 years ago and Herbert Valerio Riedel committed 6 years ago

This commit handles the most common case of issue #5325 by checking that each
component that is required as a dependency is buildable in the current
environment, where environment refers to the compiler, os, arch, and global flag
constraints.  The solver records whether each component is buildable in the
package's PInfo during index conversion.  Then it checks that each required
component is buildable in the validation phase, similar to the check for missing
components.

The buildable check can give false-positives, because it only considers flags
that are set by unqualified flag constraints, and it doesn't check whether the
intra-package dependencies of a component are buildable.  The check is also
incomplete because it is performed before any automatic flags are assigned.  It
is possible for the solver to later choose a value for a flag that makes the
package unbuildable.

This was the pre-globstar behaviour; now it is tested and documented.

Before, we were walking the directory tree recursively
unconditionally. Now we check if the pattern is recursive before doing
that, and also only check the directory's full listing if a glob
pattern is involved at all, so literal patterns are more efficient.

I fixed this in passing with #5284, but let's add a test to make sure
it stays fixed. The error message isn't perfect, but it's a lot better
than failing silently!

Closes #5195.