Matthew Pickering authored 5 years ago and Marge Bot committed 5 years ago

It is important that `heapCensus` and `LdvCensusForDead` traverse the
same areas.

`heapCensus` increases the `not_used` counter which tracks how many
closures are live but haven't been used yet.

`LdvCensusForDead` increases the `void_total` counter which tracks how
many dead closures there are.

The `LAG` is then calculated by substracting the `void_total` from
`not_used` and so it is essential that `not_used >= void_total`. This
fact is checked by quite a few assertions.

However, if a program has low maximum residency but allocates a lot in
the nursery then these assertions were failing (see #16753 and #15903)
because `LdvCensusForDead` was observing dead closures from the nursery
which totalled more than the `not_used`. The same closures were not
counted by `heapCensus`.

Therefore, it seems that the correct fix is to make `LdvCensusForDead`
agree with `heapCensus` and not traverse the nursery for dead closures.

Fixes #16100 #16753 #15903 #8982

Matthew Pickering authored 5 years ago and Marge Bot committed 5 years ago

It is possible that void_total is exactly equal to not_used and the
other assertions for this check for <= rather than <.

Matthew Pickering authored 5 years ago and Marge Bot committed 5 years ago

This implements the correct fix for #11627 by skipping over the slop
(which is zeroed) rather than adding special case logic for LARGE
ARR_WORDS which runs the risk of not performing a correct census by
ignoring any subsequent blocks.

This approach implements similar logic to that in Sanity.c

This allows us to run (but ignore the result of) fragile testcases.
Hopefully this should allow us to more easily spot when a fragile test
becomes un-fragile.

This is the same as T5611 but with an unsafe call to sleep.

The original issue, #5611, was concerned with safe calls. However, the
test inexplicably used an unsafe call. Fix this.

The test seems to have been missing the name of its script and didn't
build with HEAD. How it made it through CI is beyond me.

Oleg Grenrus authored 5 years ago and Ben Gamari committed 5 years ago

This commit partly reverts e69619e9
commit by reintroducing Sf_SafeInferred SafeHaskellMode.

We preserve whether module was declared or inferred Safe.  When
declared-Safe module imports inferred-Safe, we warn.  This inferred
status is volatile, often enough it's a happy coincidence, something
which cannot be relied upon. However, explicitly Safe or Trustworthy
packages won't accidentally become Unsafe.

Updates haddock submodule.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Metric Increase:
    haddock.Cabal

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Sleep to avoid non-determinism due to Darwin's poor mtime resolution.
Fixes #16855.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Previously, as described in Note [Primop wrappers], `hasNoBinding` would
return False in the case of `PrimOpId`s. This would result in eta
expansion of unsaturated primop applications during CorePrep. Not only
did this expansion result in unnecessary allocations, but it also meant
lead to rather nasty inconsistencies between the CAFfy-ness
determinations made by TidyPgm and CorePrep.

This fixes #16846.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

The debugging involved in finding #16846 wouldn't have been necessary
had the consistentCafInfo check been enabled. However, :wq

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Due to #16858.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Originally I was thinking of just skipping the test unless
compiled_debugged==True. However, the test will likely be useful even
without -DS, so let's run it either way.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

 * Make it pass mypy
 * Fix a typo in test name field
 * Report more stderr output
 * Report stdout output

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

This tries to put the testsuite driver into a slightly more maintainable
condition:

* Add type annotations where easily done
* Use pathlib.Path instead of str paths
* Make it pass the mypy typechecker

Andrey Mokhov authored 5 years ago and Marge Bot committed 5 years ago

This resolves #16809 (ghc/ghc#16809).

This patch removes the unnecessary dependency on configure-generated
flags `windowsHost`, `osxHost` and `iosHost`, using the information
provided by the module `System.Info` instead.

We also take care to use the `CrossCompiling` flag generated by the
configure script only after the latter had a chance to run.

Erik de Castro Lopo authored 5 years ago and Marge Bot committed 5 years ago

LLVM version numberinf changed recently. Previously, releases were numbered
4.0, 5.0 and 6.0 but with version 7, they dropped the redundant ".0".

Fix requires for Llvm detection and some code.

Ryan Scott authored 5 years ago and Marge Bot committed 5 years ago

This fixes three infelicities related to the programs that are
(and aren't) accepted with `UnliftedNewtypes`:

* Enabling `UnliftedNewtypes` would permit newtypes to have return
  kind `Id Type`, which had disastrous results (i.e., GHC panics).
* Data family declarations ending in kind `TYPE r` (for some `r`)
  weren't being accepted if `UnliftedNewtypes` wasn't enabled,
  despite the GHC proposal specifying otherwise.
* GHC wasn't warning about programs that _would_ typecheck if
  `UnliftedNewtypes` were enabled in certain common cases.

As part of fixing these issues, I factored out the logic for checking
all of the various properties about data type/data family return
kinds into a single `checkDataKindSig` function. I also cleaned up
some of the formatting in the existing error message that gets
thrown.

Fixes #16821, fixes #16827, and fixes #16829.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Previously in the case where GHC was dynamically linked we would load
static objects one-by-one by linking each into its own shared object and
dlopen'ing each in order. However, this meant that the link would fail
in the event that the objects had cyclic symbol dependencies.

Here we fix this by merging each "run" of static objects into a single
shared object and loading this.

Fixes #13786 for the case where GHC is dynamically linked.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

When we revert a CAF we must reset the STATIC_LINK field lest the GC
might ignore the CAF (e.g. as it carries the STATIC_FLAG_LIST flag) and
will consequently overlook references to object code that we are trying
to unload. This would result in the reachable object code being
unloaded. See Note [CAF lists] and Note [STATIC_LINK fields].

This fixes #16842.

Idea-due-to: Phuong Trinh <lolotp@fb.com>

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

As described in #16845.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Previously we would hackily evaluate a textual code snippet to compute
actions to disable I/O buffering and flush the stdout/stderr handles.
This broke in a number of ways (#15336, #16563).

Instead we now ship a module (`GHC.GHCi.Helpers`) with `base` containing
the needed actions. We can then easily refer to these via `Orig` names.

As noted in #16855.