Skip to content
Snippets Groups Projects
Forked from Glasgow Haskell Compiler / GHC
5597 commits behind the upstream repository.
  • Ryan Scott's avatar
    d2f9972a
    Make dataToQa aware of Data instances which use functions to implement toConstr · d2f9972a
    Ryan Scott authored
    Trac #10796 exposes a way to make `template-haskell`'s `dataToQa` function
    freak out if using a `Data` instance that produces a `Constr` (by means of
    `toConstr`) using a function name instead of a data constructor name. While
    such `Data` instances are somewhat questionable, they are nevertheless present
    in popular libraries (e.g., `containers`), so we can at least make `dataToQa`
    aware of their existence.
    
    In order to properly distinguish strings which represent variables (as opposed
    to data constructors), it was necessary to move functionality from `Lexeme` (in
    `ghc`) to `GHC.Lexeme` in a new `ghc-boot` library (which was previously named
    `bin-package-db`).
    
    Reviewed By: goldfire, thomie
    
    Differential Revision: https://phabricator.haskell.org/D1313
    
    GHC Trac Issues: #10796
    d2f9972a
    History
    Make dataToQa aware of Data instances which use functions to implement toConstr
    Ryan Scott authored
    Trac #10796 exposes a way to make `template-haskell`'s `dataToQa` function
    freak out if using a `Data` instance that produces a `Constr` (by means of
    `toConstr`) using a function name instead of a data constructor name. While
    such `Data` instances are somewhat questionable, they are nevertheless present
    in popular libraries (e.g., `containers`), so we can at least make `dataToQa`
    aware of their existence.
    
    In order to properly distinguish strings which represent variables (as opposed
    to data constructors), it was necessary to move functionality from `Lexeme` (in
    `ghc`) to `GHC.Lexeme` in a new `ghc-boot` library (which was previously named
    `bin-package-db`).
    
    Reviewed By: goldfire, thomie
    
    Differential Revision: https://phabricator.haskell.org/D1313
    
    GHC Trac Issues: #10796
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
T10796a.hs 405 B