Teo Camarasu authored 1 year ago and Marge Bot committed 1 year ago

This test leads to a lot of contention when N>2 and becomes very slow. Let's reduce the amount of work we do to compensate. Resolves #24490

Cheng Shao authored 1 year ago and Marge Bot committed 1 year ago

T23540 is fragile on 32-bit platforms. The root cause is usage of
`getEvidenceTreesAtPoint`, which internally relies on `Name`'s `Ord`
instance, which is indeterministic. The solution is adding a
deterministic `Ord` instance for `EvidenceInfo` and sorting the
evidence trees before pretty printing. Fixes #24449.

Simon Peyton Jones authored 1 year ago and Marge Bot committed 1 year ago

A small change that fixes #24489

Teo Camarasu authored 1 year ago and Teo Camarasu committed 1 year ago

In nonmovingTidyWeaks we want to check if the key of a weak pointer
lives in the non-moving heap. We do this by checking the flags of the
block the key lives in. But we need to be careful with values that live
outside the Haskell heap, since they will lack a block descriptor and
looking for one may lead to a segfault. In this case we should just
accept that it isn't on the non-moving heap.

Resolves #24492

Cheng Shao authored 1 year ago and Marge Bot committed 1 year ago

Ever since the removal of the make build system, the in tree lndir
hasn't been actually built, so this patch removes it.

jeffrey young authored 1 year ago and Marge Bot committed 1 year ago

In pursuit of #15560 and #17957 and generally removing redundancy.

Cheng Shao authored 1 year ago and Marge Bot committed 1 year ago

See added comment for details. Closes #24423.

Matthew Craven authored 1 year ago and Marge Bot committed 1 year ago

Its payload was used only for a small optimization in genAlts,
avoiding a few assignments for programs of this form:

  case NormalDataCon arg1 arg2 of x { NormalDataCon x1 x2 -> ... ; }

But when compiling with optimizations, this sort of code is
generally eliminated by case-of-known-constructor in Core-to-Core.
So it doesn't seem worth tracking and cleaning up again in StgToJS.

Teo Camarasu authored 2 years ago and Marge Bot committed 1 year ago

- Use ClosureType for InfoProv.ipDesc.
- Use ClosureType for CloneStack.closureType.
- Now ghc-heap re-exports this type from ghc-internal.

See the accompanying CLC proposal: https://github.com/haskell/core-libraries-committee/issues/210

Resolves #22600

Teo Camarasu authored 2 years ago and Marge Bot committed 1 year ago

Previously it used markdown syntax rather than Haddock syntax for code quotes

Felix Yan authored 1 year ago and Marge Bot committed 1 year ago

When calling as `cc`, GCC does not outputs lowercased "gcc" at least in 13.2.1 version here.

```
$ cc --version
cc (GCC) 13.2.1 20230801
...
```

This fails the check and outputs the confusing message: `configure: $CC is not gcc; assuming it's a reasonably new C compiler`

This patch makes it check for upper-cased "GCC" too so that it works correctly:

```
checking version of gcc... 13.2.1
```

Cheng Shao authored 1 year ago and Marge Bot committed 1 year ago

This commit enables parallelism when the hadrian/ghci scripts are
called in CI. The time bottleneck is in the hadrian build step, but
previously the build step wasn't parallelized.

Cheng Shao authored 1 year ago and Marge Bot committed 1 year ago

This commit passes -j to hadrian in the hadrian/hie-bios scripts. When
the user starts HLS in a fresh clone that has just been configured, it
takes quite a while for hie-bios to pick up the ghc flags and start
actual indexing, due to the fact that the hadrian build step defaulted
to -j1, so -j speeds things up and improve HLS user experience in GHC.
Also add -j flag to .ghcid to speed up ghcid, and sets the Windows
build root to .hie-bios which also works and unifies with other
platforms, the previous build root _hie-bios was missing from
.gitignore anyway.

Jade authored 1 year ago and Marge Bot committed 1 year ago

Fixes #13869

Happily this also allows us to eliminate a special case for Deadlock
exceptions.

Implements [CLC #198](https://github.com/haskell/core-libraries-committee/issues/198).

Currently `ghc -M` fails to account for `.hs-boot` files correctly,
leading to issues with cross-package one-shot builds failing. This
currently manifests in `GHC.Exception` due to the boot file for
`GHC.Internal.Stack`. Work around this by adding an explicit `import`,
ensuring that `GHC.Internal.Stack` is built before `GHC.Exception`.

See #24436.

This was useful when debugging

Don't lookupIds unless we actually need them.

Previously this was only exposed from `ghc-internal` which violates our
agreement that users shall not rely on things exposed from that package.

Fixes #24479.

As expected, Haddock now does more work. Less expected is that some
other testcases actually get faster, presumably due to less interface
file loading. As well, the size_hello_artifact test regressed a bit when
debug information is enabled due to debug information for the new stub
symbols.

Metric Decrease:
    T12227
    T13056
Metric Increase:
    haddock.Cabal
    haddock.base
    MultiLayerModulesTH_OneShot
    size_hello_artifact

Really, these references should be via known-key names anyways. I have
fixed the proximate issue here but have opened #24472 to track the
additional needed refactoring.

Sadly there are still a few module reexports. However, at least we have
decoupled from the exports of `GHC.Internal.Base`.

This ensures that we do not use `base` stub modules as declarations'
homes when not appropriate.

These will be incrementally moved to the export sites in `base` where
possible.

Bumps haddock submodule due to testsuite output changes.

Here we extend the parser and AST to preserve docstrings following
export items. We then extend Haddock to parse `@since` annotations in
such docstrings, allowing changes in export structure to be properly
documented.

Jade authored 1 year ago and Marge Bot committed 1 year ago

Fixes: #24476

Ben Gamari authored 1 year ago and Marge Bot committed 1 year ago

Here we extend the parser and AST to preserve docstrings following
export items. We then extend Haddock to parse `@since` annotations in
such docstrings, allowing changes in export structure to be properly
documented.

Bumps haddock submodule.

See https://github.com/ghc-proposals/ghc-proposals/pull/613

. Also
fixes #24343 and improves the documentation of language editions.

Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>

Ben Gamari authored 1 year ago and Marge Bot committed 1 year ago

This is just a minor cleanup I found while reviewing the implementation.

Andreas Klebinger authored 1 year ago and Marge Bot committed 1 year ago

Fixes #24445