Skip to content
Snippets Groups Projects
  1. Jan 01, 2019
  2. Dec 26, 2018
    • Sergei Trofimovich's avatar
      aclocal.m4: drop obsolete -fno-stack-protector · 29ecb520
      Sergei Trofimovich authored and Ben Gamari's avatar Ben Gamari committed
      
      Summary:
      Initially -fno-stack-protector was added for openbsd specifically for ghc-6.5:
          changeset:f638fdfe (2006)
      and later it was extended to cover osx:
          changeset:c2cd83e7 (2009)
      
      None of the reports hint at exact breakage. I guess both happened
      in -fvia-C mode where GHC's Evil Mangler had a chance to mangle
      stack canaries generated by fstack-protector.
      
      ghc has no evil mangler anymore and the change is not needed
      at least for C codegen.
      
      validated the patch on OpenBSD-6.4. No new failures compared to
      clean master branch.
      
      Signed-off-by: default avatarSergei Trofimovich <slyfox@gentoo.org>
      
      Test Plan: validated on OpenBSD
      
      Reviewers: bgamari
      
      Subscribers: rwbarton, erikd, carter
      
      GHC Trac Issues: #16046
      
      Differential Revision: https://phabricator.haskell.org/D5465
      29ecb520
  3. Dec 13, 2018
    • Ben Gamari's avatar
      configure: Disable LD_NO_GOLD logic when cross-compiling · 0d7fb471
      Ben Gamari authored
      This is generally terrible: see #16025. In short, we previously just blindly
      used an un-prefixed ld for LD_NO_GOLD. This is blatantly wrong. Ideally we would
      actually verify that ld.gold is indeed broken (by binutils #22266) before
      insisting on using another linker but sadly we cannot do so when cross-compiling
      since this would require running host code.
      
      For now we simply disable the LD_NO_GOLD logic when cross-compiling and hope
      that the user has verified that their ld.gold isn't affected by #22266.
      0d7fb471
  4. Nov 22, 2018
  5. Oct 29, 2018
  6. Oct 15, 2018
  7. Sep 25, 2018
  8. Sep 20, 2018
  9. Jul 28, 2018
  10. Jul 17, 2018
  11. Jul 16, 2018
  12. Jun 08, 2018
  13. Apr 19, 2018
    • Ben Gamari's avatar
      configure: Use -Werror to check for existence of -no-pie · cbd73bbb
      Ben Gamari authored and Ben Gamari's avatar Ben Gamari committed
      Clang throws a warning instead of an error when it is passed -no-pie,
      
          clang: warning: argument unused during compilation: '-nopie'
          [-Wunused-command-line-argument]
      
      Consequently configure concludes that it supports -no-pie. However, this
      will fail when used with -Werror. The solution is to simply use -Werror
      in the configure check.
      
      Thanks to @goldfire for reporting this.
      
      Reviewers: hvr
      
      Subscribers: thomie, carter, goldfire
      
      Differential Revision: https://phabricator.haskell.org/D4557
      cbd73bbb
  14. Apr 17, 2018
    • Alp Mestanogullari's avatar
      Introduce a $tooldir variable for nicer toolchain detection on Windows · 5d768464
      Alp Mestanogullari authored and Tamar Christina's avatar Tamar Christina committed
      Summary:
      This patch affects several files that affect how we detect mingw and perl
      on Windows. The initial motivation is:
      
          https://github.com/snowleopard/hadrian/issues/564
      
      where, with Hadrian building relocatable (non-inplace) GHCs, the current
      detection mechanism falls short by e.g only trying $topdir/../mingw. But
      in Hadrian, for reasons given in that issue, we would need to store e.g mingw
      under $topdir/../../mingw except for binary distributions, where we want
      to follow the existing structure, in which case $topdir/../mingw is correct. So
      we need to support both, which is what this patch hopefully implements.
      
      Test Plan: ./validate
      
      Reviewers: Phyx, hvr, bgamari, erikd
      
      Reviewed By: Phyx
      
      Subscribers: snowleopard, thomie, carter
      
      Differential Revision: https://phabricator.haskell.org/D4598
      5d768464
  15. Mar 27, 2018
  16. Mar 25, 2018
  17. Mar 19, 2018
  18. Mar 17, 2018
    • Sergei Trofimovich's avatar
      aclocal.m4: add OSHurd (debian patch) · 0693b0b0
      Sergei Trofimovich authored
      
      ghc treats OSUnknown (and GNU/Hurd) as non-ELF target.
      This causes panic in native codegenerator when trying
      to build PIC code:
      
      ```
        ...
        -- all other platforms
        howToAccessLabel dflags _ _ _ _ _
              | not (positionIndependent dflags)
              = AccessDirectly
              | otherwise
              = panic "howToAccessLabel: PIC not defined for this platform"
      ```
      
      This change declares new 'OSHurd' and marks it as an
      ELF target. Fixes building ghc-stage2 on i686-unknown-gnu0.9.
      
      Patch provided by "Pino" via Samuel Thibault and taken from
      debian.
      
      Signed-off-by: default avatarSergei Trofimovich <slyfox@gentoo.org>
      0693b0b0
    • Sergei Trofimovich's avatar
      aclocal.m4: allow more GNU/Hurd tuples · 1522cf05
      Sergei Trofimovich authored
      
      Running plain ./configure fails on hurd because
      ./config.guess reports unrecognised tuple:
          $ ./config.guess
          i686-unknown-gnu0.9
      
      The change makes the following target configure:
      $ ./configure --target=i686-unknown-gnu0.9
      
      Signed-off-by: default avatarSergei Trofimovich <slyfox@gentoo.org>
      1522cf05
  19. Mar 08, 2018
  20. Mar 02, 2018
  21. Feb 21, 2018
  22. Feb 15, 2018
  23. Feb 03, 2018
  24. Dec 25, 2017
  25. Nov 21, 2017
    • Ben Gamari's avatar
      configure: Fix ar probed flags · 66d17995
      Ben Gamari authored and Ben Gamari's avatar Ben Gamari committed
      FP_PROG_AR_ARGS appears to be probing for what flags to use to build an
      archive with an index. However, none of the flags that it probed
      previously were valid as they all started with `c`, which isn't a mode
      character. This went unnoticed until someone attempted to use LLVM ar
      since we have a special case for gnu ar.
      
      Additionally, we work around a bug in llvm-ar 5.0 where ar will exit
      with code 0 even if it fails to parse the command line. Silliness.
      
      I believe these should rather all be mode `q` however I'll need to test
      this on a few platforms to be certain.
      
      Test Plan: Validate on OS X, BSD, and Linux with binutils and llvm ar
      
      Reviewers: hvr
      
      Subscribers: rwbarton, thomie, erikd
      
      Differential Revision: https://phabricator.haskell.org/D4214
      66d17995
  26. Nov 15, 2017
    • Moritz Angermann's avatar
      Adds rts/rts.cabal.in file · 5dea62fb
      Moritz Angermann authored and Ben Gamari's avatar Ben Gamari committed
      This is in preparation for cabalification of the `rts`. To be actually
      able to parse this file, a rather recent Cabal is required. One after
      commit 357d49d of haskell/cabal. The relevant PR to support the new
      `asm-sources` and `cmm-sources` is haskell/cabal/pull/4857.
      
      Not that this does *not* allow cabal to build the RTS. It does however
      provide enough information such that cabal can `copy` and `register`
      the package properly in the package database, if all the build
      artifacts have been build properly.
      
      As such it does not require any custom handling of the `rts` package.
      As the rts as well as all the other packages built by the GHC built
      system are built outside of cabal anyway.
      
      Reviewers: bgamari, hvr, erikd, simonmar
      
      Reviewed By: bgamari
      
      Subscribers: rwbarton, thomie, erikd
      
      Differential Revision: https://phabricator.haskell.org/D4174
      5dea62fb
  27. Nov 06, 2017
    • Peter Trommler's avatar
      Update autoconf test for gcc to require 4.7 and up · 59de2909
      Peter Trommler authored and Ben Gamari's avatar Ben Gamari committed
      Fixing #14244 required the newer gcc atomic built-ins that are provided
      from 4.7 and up. This updates the test to check for minimum gcc version
      4.7.
      
      The version tests for 3.4 (!), 4.4, and 4.6 are no longer needed and can
      be removed. This makes the build system simpler.
      
      Test Plan: validate
      
      Reviewers: austin, bgamari, hvr, simonmar
      
      Reviewed By: bgamari
      
      Subscribers: rwbarton, thomie, erikd
      
      Differential Revision: https://phabricator.haskell.org/D4165
      59de2909
  28. Oct 26, 2017
  29. Oct 16, 2017
    • Ben Gamari's avatar
      configure: Fix CC version check on Apple compilers · 71a42356
      Ben Gamari authored and Ben Gamari's avatar Ben Gamari committed
      It seems that some Apple LLVM wrappers emit multiple messages containing
      the string "version", which we previously used to find the version
      number.  For instance,
      
          Configured with: --prefix=/Applications/Xcode.app/Contents/...
          Apple LLVM version 9.0.0 (clang-900.0.37)
          Target: x86_64-apple-darwin16.7.0
          Thread model: posix
          InstalledDir: /Applications/Xcode.app/Contents/Developer/...
          Found CUDA installation: /usr/local/cuda, version 8.0
      
      We now take care to only look at the first occurrence of this string.
      
      New `sed` command due to @merijn.
      
      Test Plan: Validate on all the compilers
      
      Reviewers: austin, hvr
      
      Subscribers: rwbarton, thomie, merijn, erikd
      
      Differential Revision: https://phabricator.haskell.org/D4069
      71a42356
  30. Oct 04, 2017
  31. Sep 29, 2017
  32. Sep 27, 2017
    • Ben Gamari's avatar
      configure: Make sure we try all possible linkers · a10729f0
      Ben Gamari authored and Ben Gamari's avatar Ben Gamari committed
      Previously if we had both ld.lld and ld.gold installed but a gcc which
      didn't support -fuse-ld=lld we would fail when trying ld.lld and fall
      immediately back to plain ld. Now we will try ld.gold as well. This was
      brought to light by #14280, where using ld.bfd resulted in a broken
      stage2 compiler.
      
      Test Plan: Configure
      
      Reviewers: angerman, hvr, austin
      
      Reviewed By: angerman
      
      Subscribers: rwbarton, thomie, erikd
      
      GHC Trac Issues: #14280
      
      Differential Revision: https://phabricator.haskell.org/D4038
      a10729f0
    • Moritz Angermann's avatar
      GHC_LLVM_TARGET: Keep android OS · 07ddeaf7
      Moritz Angermann authored
      Summary:
      Our usual GHC_CONVERT_OS macro, will turn any andoird* into android.
      This however drops the essential androideabi part. As such for the
      GHC_LLVM_TARGET we only convert the VENDOR, not the OS.
      
      Reviewers: bgamari, austin, hvr
      
      Reviewed By: bgamari
      
      Subscribers: rwbarton, thomie, erikd
      
      Differential Revision: https://phabricator.haskell.org/D4031
      07ddeaf7
  33. Sep 26, 2017
  34. Sep 25, 2017
  35. Sep 23, 2017
  36. Sep 20, 2017
  37. Sep 13, 2017
Loading