There is no libstdc++, only libc++

Ben Gamari authored 5 years ago and Moritz Angermann committed 4 years ago

Previously we were invoking:

    bash -c
    "c:/GitLabRunner/builds/eEQrxK4p/0/ghc/ghc/toolchain/bin/ghc.exe.exe
    testsuite/mk/ghc-config.hs -o _build/test/bin/ghc-config.exe"

Notes appear to be 8byte aligned instead of 4 as on x86_64 

See: https://reviews.llvm.org/D70962

> The .note.gnu.property SHT_NOTE sections on AArch64 (a 64-bit target) should have alignment 8 to more closely match the binutils implementation where alignment is 4-bytes on 32-bit machines and 8-bytes on 64-bit machines.
> Previously LLD was using 4 for both 32-bit and 64-bit machines.
> There was a long discussion on the right alignment of the .note.gnu.property section on the binutils mailing list. The basic argument was that generic ELF requires 8-byte alignment for SHT_NOTES sections, however this hadn't been respected by other GNU notes sections. The implementation in GNU ld uses 8 and as there is no binary legacy of using 4 in LLD (BTI is only just being picked up and used) I'd like to keep LLD in line with GNU ld.
> Although at present LLD only does something useful with AArch64 properties, this also applies to X86.

This resolves the following:

Compile failed (exit code 1) errors were:
conc059_c.c:27:5: error:
     error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
        exit(0);
        ^
conc059_c.c:27:5: error:
     note: include the header <stdlib.h> or explicitly provide a declaration for 'exit'

So we did *not* have the stgCallocBytes prototype, and subsequently
the C compiler defaulted to `int` as a return value. Thus generating
sxtw instructions for the return value of stgCalloBytes to produce
the expected void *.

Ben Gamari authored 5 years ago and Moritz Angermann committed 4 years ago

Due to #17607.

markLiveObject is called by GC worker threads and therefore must be
thread-safe. This was a rather egregious oversight which the testsuite
missed.

We don't pass MAKE_ARGS for windows builds, so this should unbreak
them.

Ben Gamari authored 4 years ago and Moritz Angermann committed 4 years ago

We now have a proper periodic clean-up script installed on the runners.

See ghc/ghc#17018

This drops allocateExec for darwin, and replaces it with
a alloc, write, mark executable strategy instead. This prevents
us from trying to allocate an executable range and then write to
it, which X^W will prohibit on darwin.

This will *only* work if we can use mmap.

_AC_PROG_CC_99 isn't available anymore in recent autoconf versions.
This broke on aarch64-darwin.

This breaks lots of tests unnecessarily. The LLVM IR
has been pretty stable since ~7.  This stops GHC from
emitting the warnings during the testsuite run.

This may be necessary when building stage2 cross compiled
compilers.

Ben Gamari authored 4 years ago and Moritz Angermann committed 4 years ago

To support proper parsing of arm64 targets, we needed to adjust
the GHC_LLVM_TARGET function to allow parsing arm64-apple-darwin
into aarch64. This however discared the proper os detection.

To rectify this, we'll pull the os detection into separate block.

Fixes #19173.

This is a pre-requisite for making aarch64-darwin work.

This is needed so that the codegen can produce C ABI calls
that require knowledge about the actual size of arguments.

Specifically aarch64-darwin will require arguments (in exess
of available registers) to be passed *packed* on the stack.

this prevents the testlib/driver to be overly noisy, and will also
kill some noise produiced by the aarch64-darwin cc (for now).

Fixing sysctl, will allow us to run the test's properly in a nix-shell
on aarch64-darwin

this is effectively now required.

arm64 is really only a name apple uses, and we should
refrain from using it across multiple architectures.
Let's call aarch64-darwin, arm64 if needed, but otherwise
stick to aarch64.

     int
     memcmp(const void *s1, const void *s2, size_t n);

     size_t
     strlen(const char *s);