Skip to content
Snippets Groups Projects
  1. Jun 27, 2021
  2. Jun 25, 2021
  3. Jun 24, 2021
  4. Jun 23, 2021
    • Douglas Wilson's avatar
      ci: Don't allow the nightly pipeline to be interrupted. · 633bbc1f
      Douglas Wilson authored and Matthew Pickering's avatar Matthew Pickering committed
      Since 58cfcc65 the default for jobs has been "interruptible", this means
      that when new commits are pushed to a branch which already has a running
      pipeline then the old pipelines for this branch are cancelled.
      
      This includes the master branch, and in particular, new commits merged
      to the master branch will cancel the nightly job.
      
      The semantics of pipeline cancelling are actually a bit more complicated
      though. The interruptible flag is *per job*, but once a pipeline has run
      *any* non-interruptible job, then the whole pipeline is considered
      non-interruptible (ref
      https://gitlab.com/gitlab-org/gitlab/-/issues/32837
      
      ). This leads to the
      hack in this MR where by default all jobs are `interruptible: True`, but
      for pipelines we definitely want to run, there is a dummy job which
      happens first, which is `interreuptible: False`. This has the effect of
      dirtying the whole pipeline and preventing another push to master from
      cancelling it.
      
      For now, this patch solves the immediate problem of making sure nightly
      jobs are not cancelled.
      In the future, we may want to enable this job also for the master
      branch, making that change might mean we need more CI capacity than
      currently available.
      
      [skip ci]
      
      Ticket: #19554
      
      Co-authored-by: default avatarMatthew Pickering <matthewtpickering@gmail.com>
      633bbc1f
    • Moritz Angermann's avatar
      [testsuite] mark T3007 broken on darwin. · 8fba28ec
      Moritz Angermann authored and Marge Bot's avatar Marge Bot committed
      Cabal explicitly passes options to set the rpath, which we then also try
      to set using install_name_tool. Cabal should also pass `-fno-use-rpaths`
      to suppress the setting of the rpath from within GHC.
      8fba28ec
    • Matthew Pickering's avatar
      hadrian: Pass correct leading_underscore configuration to tests · 6bf82316
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      6bf82316
    • Matthew Pickering's avatar
      ghci: Correct free variable calculation in StgToByteCode · d8e5b274
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      Fixes #20019
      d8e5b274
    • sheaf's avatar
      Enable TcPlugin tests on Windows · aa1d0eb3
      sheaf authored and Marge Bot's avatar Marge Bot committed
      aa1d0eb3
    • Matthew Pickering's avatar
      testsuite: Don't try to run tests with missing libraries · e14b893a
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      As noticed by sgraf, we were still running reqlib tests, even if the
      library was not available. The reasons for this were not clear to me as
      they would never work and it was causing some issues with empty stderr
      files being generated if you used --test-accept.
      
      Now if the required library is not there, the test is just skipped, and
      a counter increased to mark the fact.
      
      Perhaps in the future it would be nicer to explicitly record why certain
      tests are skipped. Missing libraries causing a skip is a special case
      at the moment.
      
      Fixes #20005
      e14b893a
    • Matthew Pickering's avatar
      Optimiser: Correctly deal with strings starting with unicode characters in exprConApp_maybe · 7f6454fb
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      For example:
      
      "\0" is encoded to "C0 80", then the rule would correct use a decoding
      function to work out the first character was "C0 80" but then just used
      BS.tail so the rest of the string was "80". This resulted in
      
      "\0" being transformed into '\C0\80' : unpackCStringUTF8# "80"
      
      Which is obviously bogus.
      
      I rewrote the function to call utf8UnconsByteString directly and avoid
      the roundtrip through Faststring so now the head/tail is computed by the
      same call.
      
      Fixes #19976
      7f6454fb
    • adam's avatar
      ci: fix ci.sh by creating build.mk in one place · 87f57ecf
      adam authored and Marge Bot's avatar Marge Bot committed
      Previously `prepare_build_mk` created a build.mk that was overwritten right
      after.
      
      This makes the BIGNUM_BACKEND choice take effect, fixing #19953, and
      causing the metric increase below in the integer-simple job.
      
      Metric Increase:
          space_leak_001
      87f57ecf
  5. Jun 22, 2021
    • Potato Hatsue's avatar
      Fix a typo in pattern synonyms doc · 62d720db
      Potato Hatsue authored and Marge Bot's avatar Marge Bot committed
      62d720db
    • Matthew Pickering's avatar
      ghc-bignum: trimed ~> trimmed · f7e41d78
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      Just a small typo which propagated through ghc-bignum
      f7e41d78
    • Krzysztof Gogolewski's avatar
      Typos, minor comment fixes · 362f078e
      Krzysztof Gogolewski authored and Marge Bot's avatar Marge Bot committed
      - Remove fstName, sndName, fstIdKey, sndIdKey - no longer used,
        removed from basicKnownKeyNames
      - Remove breakpointId, breakpointCondId, opaqueTyCon, unknownTyCon -
        they were used in the old implementation of the GHCi debugger
      - Fix typos in comments
      - Remove outdated comment in Lint.hs
      - Use 'LitRubbish' instead of 'RubbishLit' for consistency
      - Remove comment about subkinding - superseded by
        Note [Kind Constraint and kind Type]
      - Mention ticket ID in a linear types error message
      - Fix formatting in using-warnings.rst and linear-types.rst
      - Remove comment about 'Any' in Dynamic.hs - Dynamic
        now uses Typeable + existential instead of Any
      - Remove codeGen/should_compile/T13233.hs
        This was added by accident, it is not used and T13233 is already in
        should_fail
      362f078e
    • Matthew Pickering's avatar
      rts: Document --eventlog-flush-interval in RtsFlags · 595dfbb0
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      Fixes #19995
      595dfbb0
    • Sylvain Henry's avatar
      Put tracing functions into their own module · 14956cb8
      Sylvain Henry authored and Marge Bot's avatar Marge Bot committed
      Now that Outputable is independent of DynFlags, we can put tracing
      functions using SDocs into their own module that doesn't transitively
      depend on any GHC.Driver.* module.
      
      A few modules needed to be moved to avoid loops in DEBUG mode.
      14956cb8
Loading