Skip to content
Snippets Groups Projects
  1. Aug 18, 2022
  2. Aug 16, 2022
  3. Aug 11, 2022
  4. Aug 10, 2022
    • Alexander Kaznacheev's avatar
      ncg/aarch64: Don't use x18 register on AArch64/Darwin · 67575f20
      Alexander Kaznacheev authored and Marge Bot's avatar Marge Bot committed
      Apple's ABI documentation [1] says: "The platforms reserve register x18.
      Don’t use this register." While this wasn't problematic in previous
      Darwin releases, macOS 13 appears to start zeroing this register
      periodically. See #21964.
      
      [1] https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms
      67575f20
    • Ben Gamari's avatar
      hadrian: Don't attempt to install documentation if doc/ doesn't exist · 7cabea7c
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      Previously we would attempt to install documentation even if the `doc`
      directory doesn't exist (e.g. due to `--docs=none`). This would result
      in the surprising side-effect of the entire contents of the bindist
      being installed in the destination documentation directory. Fix this.
      
      Fixes #21976.
      7cabea7c
    • Ben Gamari's avatar
      gitlab-ci: Run ARMv7 jobs when ~ARM label is used · 596db9a5
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      596db9a5
    • Ben Gamari's avatar
      gitlab-ci: Fix ARMv7 build · 5bc489ca
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      It appears that the CI refactoring carried out in
      5ff690b8 failed to carry over some
      critical configuration: setting the build/host/target platforms and
      forcing use of a non-broken linker.
      5bc489ca
    • Sylvain Henry's avatar
      Add support for external static plugins (#20964) · f95bbdca
      Sylvain Henry authored and Marge Bot's avatar Marge Bot committed
      
      This patch adds a new command-line flag:
      
        -fplugin-library=<file-path>;<unit-id>;<module>;<args>
      
      used like this:
      
        -fplugin-library=path/to/plugin.so;package-123;Plugin.Module;["Argument","List"]
      
      It allows a plugin to be loaded directly from a shared library. With
      this approach, GHC doesn't compile anything for the plugin and doesn't
      load any .hi file for the plugin and its dependencies. As such GHC
      doesn't need to support two environments (one for plugins, one for
      target code), which was the more ambitious approach tracked in #14335.
      
      Fix #20964
      
      Co-authored-by: default avatarJosh Meredith <joshmeredith2008@gmail.com>
      f95bbdca
    • Jens Petersen's avatar
      hadrian RunRest: add type signature for stageNumber · 823fe5b5
      Jens Petersen authored and Marge Bot's avatar Marge Bot committed
      avoids warning seen on 9.4.1:
      
      src/Settings/Builders/RunTest.hs:264:53: warning: [-Wtype-defaults]
          • Defaulting the following constraints to type ‘Integer’
              (Show a0)
                arising from a use of ‘show’
                at src/Settings/Builders/RunTest.hs:264:53-84
              (Num a0)
                arising from a use of ‘stageNumber’
                at src/Settings/Builders/RunTest.hs:264:59-83
          • In the second argument of ‘(++)’, namely
              ‘show (stageNumber (C.stage ctx))’
            In the second argument of ‘($)’, namely
              ‘"config.stage=" ++ show (stageNumber (C.stage ctx))’
            In the expression:
              arg $ "config.stage=" ++ show (stageNumber (C.stage ctx))
          |
      264 |             , arg "-e", arg $ "config.stage="    ++ show (stageNumber (C.stage ctx))
          |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      
      compilation tested locally
      823fe5b5
    • Trevis Elser's avatar
      Updates language extension documentation · dc76439d
      Trevis Elser authored and Marge Bot's avatar Marge Bot committed
      Adding a 'Status' field with a few values:
      - Deprecated
      - Experimental
      - InternalUseOnly
      - Noting if included in 'GHC2021', 'Haskell2010' or 'Haskell98'
      
      Those values are pulled from the existing descriptions or elsewhere in
      the documentation.
      
      While at it, include the :implied by: where appropriate, to provide
      more detail.
      
      Fixes #21475
      dc76439d
    • Douglas Wilson's avatar
      base: Fix races in IOManager (setNumCapabilities,closeFdWith) · 7589ee72
      Douglas Wilson authored and Marge Bot's avatar Marge Bot committed
      Fix for #21651
      
      Fixes three bugs:
      
      - writes to eventManager should be atomic. It is accessed concurrently by ioManagerCapabilitiesChanged and closeFdWith.
      - The race in closeFdWith described in the ticket.
      - A race in getSystemEventManager where it accesses the 'IOArray' in
        'eventManager' before 'ioManagerCapabilitiesChanged' has written to
        'eventManager', causing an Array Index exception. The fix here is to
        'yield' and retry.
      7589ee72
    • Douglas Wilson's avatar
      testsuite: 21651 add test for closeFdWith + setNumCapabilities · 76b52cf0
      Douglas Wilson authored and Marge Bot's avatar Marge Bot committed
      This bug does not affect windows, which does not use the
      base module GHC.Event.Thread.
      76b52cf0
  5. Aug 09, 2022
    • sheaf's avatar
      Fix size_up_alloc to account for UnliftedDatatypes · d71a2051
      sheaf authored and Marge Bot's avatar Marge Bot committed
      The size_up_alloc function mistakenly considered any type that isn't
      lifted to not allocate anything, which is wrong. What we want instead
      is to check the type isn't boxed. This accounts for (BoxedRep Unlifted).
      
      Fixes #21939
      d71a2051
    • Ben Gamari's avatar
      gitlab-ci: Bump to use freebsd13 runners · ea90e61d
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      ea90e61d
    • Ben Gamari's avatar
      system-cxx-std-lib: Add support for FreeBSD libcxxrt · 5d66a0ce
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      5d66a0ce
    • Ben Gamari's avatar
      rts/linker: Resolve iconv_* on FreeBSD · 66d2e927
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      FreeBSD's libiconv includes an implementation of the
      iconv_* functions in libc. Unfortunately these can
      only be resolved using dlvsym, which is how the RTS linker
      usually resolves such functions. To fix this we include an ad-hoc
      special case for iconv_*.
      
      Fixes #20354.
      66d2e927
    • Krzysztof Gogolewski's avatar
      Cleanups around pretty-printing · e9dfd26a
      Krzysztof Gogolewski authored and Marge Bot's avatar Marge Bot committed
      * Remove hack when printing OccNames. No longer needed since e3dcc0d5
      * Remove unused `pprCmms` and `instance Outputable Instr`
      * Simplify `pprCLabel` (no need to pass platform)
      * Remove evil `Show`/`Eq` instances for `SDoc`. They were needed by
        ImmLit, but that can take just a String instead.
      * Remove instance `Outputable CLabel` - proper output of labels
        needs a platform, and is done by the `OutputableP` instance
      e9dfd26a
    • Ben Gamari's avatar
      hadrian: Fix access mode of installed package registration files · 681aa076
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      Previously hadrian's bindist Makefile would modify package
      registrations placed by `install` via a shell pipeline and `mv`.
      However, the use of `mv` means that if umask is set then the user may
      otherwise end up with package registrations which are inaccessible.
      Fix this by ensuring that the mode is 0644.
      681aa076
    • Ben Gamari's avatar
      hadrian: Fix bindist installation on Darwin · 1c582f44
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      It turns out that `cp -P` on Darwin does not always copy a symlink as
      a symlink. In order to get these semantics one must pass `-RP`. It's not
      entirely clear whether this is valid under POSIX, but it is nevertheless
      what Apple does.
      1c582f44
    • Ben Gamari's avatar
      gitlab-ci: Don't use coreutils on Darwin · c1c08bd8
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      In general we want to ensure that the tested environment is as similar
      as possible to the environment the user will use. In the case of Darwin,
      this means we want to use the system's BSD command-line utilities, not
      coreutils.
      
      This would have caught #21974.
      c1c08bd8
  6. Aug 08, 2022
Loading