Export DynFlags.flagSpecOf

HLS has had to effectively re-implement it. PR. Relevant lines.

added needs triage label

wWarningFlags is exported, so you can easily reimplement flagSpecOf in ghcide even if it's not exported.

Perhaps there is no harm in exporting it but I don't think it's as much of a problem as it could be.

added GHC API Ttask labels and removed needs triage label

@georgefst , as @mpickering mentioned, it looks like wWarningFlags is indeed exported. I would this that using this would eliminate much of the code in the module you cited. Is there a reason this doesn't work?

Thanks. We'd missed that wWarningFlags does most of the work, and is exported. I'm not sure there is much to be gained by exporting flagSpecOf after all.

Following the latest comments on that PR, the one thing that might be useful would be an Ord instance for WarningFlag, so that it could be put in a Map.

Sounds reasonable to me. Perhaps you could open an MR?

mentioned in merge request !4690 (closed)

mentioned in issue #19708 (closed)

changed milestone to %9.2.1

added Phigh label

mentioned in merge request !6557 (closed)

mentioned in commit cc067d2d

mentioned in commit bfb4df84

mentioned in commit 96052e8c

mentioned in commit da24091e

mentioned in merge request !6719 (merged)

mentioned in commit ba4754eb

closed with commit 8300ca2e

mentioned in commit 8300ca2e