binary-0.8.0.0 will provide Binary Version

Show details direct

This mode implements #2911, and allows to connect the test runner
directly to stdout/stdin. This is more reliable in the presence of no
threading, i.e. a work-arond for #2398.

I make the test suite use this, so that it passes again, despite
printing lots of stuff. Once #2398 is fixed properly, the test suite
should probably be extended to test all the various --show-details
modes.

Update Travis job to use GHC 7.10.3

Implement `cabal upload --doc`

The test case is changed to print a rather large amount of text, large
enough to fill a buffer. This way, the buffer draining functionality in
the test runner is tested, and it reveals #2398.

This makes the test suite currently fail, of course, but the bug was
there before.

This gives newcomers like me a better chance to understand how the Cabal
test suite is constructed.

The powershell script contains the password, so writing it to a file
is a bit unsafe. We know pass it via stdin.
This commit also improves the error message for network failures a
little bit.

Passing passwords via command line arguments is insecure: anyone who
is able to read the process list on the system can read the passwords
as well.

For curl, we pass the password via stdin by using the --config option,
which allows us to pass arbitrary additional options via stdin.

Unfortunately, wget's --config option does not support - for stdin. So
we instead use the --input-file option to pass an URI with the password
via stdin.

Bench.hs: use exitSuccess and forM

Solver: limit where package target constraints apply

When we have a target like "foo-1.0", in terms of solver input this
gets turned into a target package name of "foo" and a (labelled)
constraint of "foo == 1.0". This constraint is of course to ensure
that we pick the right target. However, with the recent addition of
qualified package goals we have the possibility of picking multiple
versions of the same package (e.g. via setup deps). If we have a
constraint like "foo == 1.0" apply everywhere then it becomes
impossible to pick multiple versions of package "foo", which may
mean we cannot find a solution at all. But the constraint for the
target need not apply everywhere, it's just to ensure that for the
"main" instance, we pick the right version.

This patch makes that precise. We have these constraints arising
from targets apply only to package name goals that are suitably
unqualified: qualifications arising from independent goals and from
base version trickery are ok, but qualifiactions from setup deps
are not. Or to put it another way, these target constraints do not
apply to goals arising as the result of setup dependencies.

As a more concrete example, this allows a situation where a package
needs an old version of Cabal as a setup dep, but a new version of
Cabal is also present in the main part of the solution as a normal
library dep. Whenever we solve for that main Cabal lib as a target
it would previously fail (it would be impossible to satisfy the
conflicting constraints on the Cabal setup dep) and it now works.

The only change between process 1.3 and 1.4 is:

"Added child_user and child_group to CreateProcess for unix. #45"

And the relevant code in Cabal doesn't seem affected by those additional
members.

	Bump lower bounds of dependencies 

https://ghc.haskell.org/trac/ghc/wiki/Commentary/Libraries/VersionHistory

CPP-reducing refactoring

This refactoring allows to drop `{-# LANGUAGE CPP #-}` from a couple of
modules again.

cabal-install Upload.hs flip mapM_ -> forM_

why DeriveGeneric is there?

Check.hs catMaybes . map -> mapMaybe

This fixes an issue in the curl transport when a text response is returned
that doesn't end with a newline from a POST or PUT request. The code expects
the HTTP status code to be on a new line, but that is not the case if the response
doesn't have a trailing new line. We fix this by always printing a new line before
printing the status code. To avoid duplicate new lines, we now strip trailing empty
lines at the end of the response.

This commit refactors the powershell transport to avoid duplication and
also fixes a few problems with it:

* We now run powershell with the ExecutionPolicy bypass, is required when
  the default security policy disallows executing unsigned scripts
  (like our script)
* The powershell script itself has been refactored to behave more like
  curl. In particular, it now prints HTTP status code errors in a nicer
  way instead of failing with a PowerShell Exception + backtrack. We also
  now only print the exception message when we get any other exception,
  since the user is likely not familar with the powershell script at all
  and the other information is thus only confusing and not helpful at all.
* We now handle the case where the server returns some message after a
  POST or a PUT correctly. Previously, that resulted in the raw bytes
  being written to stdout before the HTTP status code, which confused the
  simplistic parser. We now always write the HTTP status code first and
  decode the bytes as UTF8 before sending them to stdout as well.

ReadP.hs : use >=> and replicateM from Control.Monad

Configuration.hs: catMaybes . map -> mapMaybe