andreas.abel authored 3 years ago and Mikolaj Konarski committed 3 years ago

Strict regime: turn warnings to errors (-W), rebuild from scratch (-E).

- regenerate bootstrap plans
- update CI and docker images for 8.8.4 and 8.10.4

* Changes needed for GenValidate and release.py to
  accommmodate new solver dependency
* Bumps bootstrap plans to modern GHC versions
* Update `validate.sh` and `release.py` to accommodate new solver dep.
* Update `Makefile` targets

The are various motivation points:
- I'm not aware anyone third party running Cabal tests (maybe nixpkgs?)
- No need to do gen-extra-source-files, as Cabal-tests is not distributed
- No multiple rebuilds of Cabal-QuickCheck, Cabal-tree-diff
- Slightly smaller Cabal sdist (which is quite big still)

This makes us skip one less test.
Also some small cleanups to test runner added.

The folder contains also `Lexer.x`, which isn't a template as such,
but it's not far from that, conceptually. `templates/` is better
name than `boot/`

I.e. find out where we don't yet
used `Distribution.Client.Compat.Prelude`.

- If the module is small I added direct `Prelude` imports.
- Add Exception, deepseq stuff to Cabal Prelude
- Add Parsec, Pretty and Verbosity to Client Prelude
- use for, for_, traverse and traverse_ (removes need for Control.Monad)

Also add a test for current behaviour
of https://github.com/haskell/cabal/issues/6083

And variant with mixin, for https://github.com/haskell/cabal/issues/6281

The tests are disable for GHC older than 8.8
Should they work?

Also add validate-8.10.1 make rule

Note all Described instances are implemented. This is just a start.

No "manual" string concatenation,
and the template arguments are typed.

Also split workflows into parts, helps with restarting.
https://github.community/t5/GitHub-Actions/re-run-jobs/m-p/30476#M440