Matthew Pickering authored 4 years ago and Marge Bot committed 4 years ago

The BLOCKS_SIZE event reports the size of the currently allocated blocks
in bytes.

It is like the HEAP_SIZE event, but reports about the blocks rather than
megablocks.

You can work out the current heap fragmentation by looking at the
difference between HEAP_SIZE and BLOCKS_SIZE.

Fixes #19357

Matthew Pickering authored 4 years ago and Marge Bot committed 4 years ago

See #19357

The event reports the
  * Current number of megablocks allocated
  * The number that the RTS thinks it needs
  * The number is managed to return to the OS

When current > need then the difference is returned to the OS, the
successful number of returned mblocks is reported by 'returned'.

In a fragmented heap current > need but returned < current - need.

Peter Trommler authored 4 years ago and Marge Bot committed 4 years ago

Fixes #19409

This implements the BoxedRep proposal, refactoring the `RuntimeRep`
hierarchy from:

```haskell
data RuntimeRep = LiftedPtrRep | UnliftedPtrRep | ...
```

to

```haskell
data RuntimeRep = BoxedRep Levity | ...
data Levity = Lifted | Unlifted
```

Updates binary, haddock submodules.

Closes #17526.

Metric Increase:
    T12545

Ben Gamari authored 4 years ago and Marge Bot committed 4 years ago

This mirrors the make build system and ensures that we don't end up with
references to the build directory in the final executable.

Fixes #19485.

Sylvain Henry authored 4 years ago and Marge Bot committed 4 years ago

Using .gitatttributes, we don't require users to set git's core.autocrlf
setting to false on Windows to be able to checkout a working tree.

Andreas Schwab authored 4 years ago and Marge Bot committed 4 years ago

This enables a registerised build for the riscv64 architecture.

Andreas Klebinger authored 4 years ago and Marge Bot committed 4 years ago

This fixes #19484. In detail we:

* Bump the index-state of hackage.
* Require alex-3.2.6, as alex-3.2.5 doesn't build with 9.0.
* Allow Cabal-3.4 as 3.2 doesn't build with ghc 9.0.
* Allow a newer QuickCheck version that accepts the new base version.
* Some code changes to account for Cabal changes.

hdgarrood authored 4 years ago and Marge Bot committed 4 years ago

This is something that's quite important for the correctness of the
incremental build system and doesn't appear to be tested currently; this
test fails on my hashing branch, whereas all of the other (non-perf)
tests pass.

Krzysztof Gogolewski authored 4 years ago and Marge Bot committed 4 years ago

This addresses points (1a) and (1b) of #19165.

- Move mkFailExpr to HsToCore/Utils, as it can be shared
- Desugar incomplete patterns and holes to an empty case,
  as in Note [Incompleteness and linearity]
- Enable linear linting of desugarer output
- Mark MultConstructor as broken. It fails Lint, but I'd like to fix this
  separately.

Metric Decrease:
    T6048

Ben Gamari authored 4 years ago and Marge Bot committed 4 years ago

Previously this test did nothing to prevent GHC from reading .ghci due
to the `-e` arguments. Consequently it could fail due to multiple
reloadings of DynFlags while evaluating .ghci.

cgibbard authored 4 years ago and Marge Bot committed 4 years ago

Commit 2a942285 dramatically simplified the implementation and improved
the performance of COMPLETE sets while making them applicable in more
scenarios at the same time.
But it turned out that there was a change in semantics that (to me
unexpectedly) broke users' expectations (see #14422): They relied on the
"type signature" of a COMPLETE pragma to restrict the scrutinee types of
a pattern match for which they are applicable.

This patch brings back that filtering, so the semantics is the same as
it was in GHC 9.0.
See the updated Note [Implementation of COMPLETE pragmas].

There are a few testsuite output changes (`completesig13`, `T14422`)
which assert this change.

Co-authored-by: Sebastian Graf <sebastian.graf@kit.edu>

Ben Gamari authored 4 years ago and Marge Bot committed 4 years ago

Fixes #19455.

Ben Gamari authored 4 years ago and Marge Bot committed 4 years ago

markLiveObject is called by GC worker threads and therefore must be
thread-safe. This was a rather egregious oversight which the testsuite
missed.


(cherry picked from commit fe28a062)

Ben Gamari authored 4 years ago and Marge Bot committed 4 years ago

This was fixed as a result of #19181.

Matthew Pickering authored 4 years ago and Marge Bot committed 4 years ago

This produces much more detailed ticky profiles which include names of
constructors.

Related !3340 !2098

Fixes #19403

Krzysztof Gogolewski authored 4 years ago and Marge Bot committed 4 years ago

Part of #17804.

During testing it was observed that quite a few info tables were not
being given locations (due to not being assigned source locations,
because they were not enclosed by a source note). We can at least give
the module name and type for such closures even if no more accurate
source information.

Especially for constructors this helps find them in the STG dumps.

The `whereFrom` function provides a Haskell interface for using the
information created by `-finfo-table-map`. Given a Haskell value, the
info table address will be passed to the `lookupIPE` function in order
to attempt to find the source location information for that particular closure.

At the moment it's not possible to distinguish the absense of the map
and a failed lookup.

The `-fdistinct-constructor-tables` flag will generate a fresh info
table for the usage of any data constructor. This is useful for
debugging as now by inspecting the info table, you can determine which
usage of a constructor caused that allocation rather than the old
situation where the info table always mapped to the definition site of
the data constructor which is useless.

In conjunction with `-hi` and `-finfo-table-map` this gives a more fine
grained understanding of where constructor allocations arise from in a
program.

This new flag embeds a lookup table from the address of an info table
to information about that info table.

The main interface for consulting the map is the `lookupIPE` C function

> InfoProvEnt * lookupIPE(StgInfoTable *info)

The `InfoProvEnt` has the following structure:

> typedef struct InfoProv_{
>     char * table_name;
>     char * closure_desc;
>     char * ty_desc;
>     char * label;
>     char * module;
>     char * srcloc;
> } InfoProv;
>
> typedef struct InfoProvEnt_ {
>     StgInfoTable * info;
>     InfoProv prov;
>     struct InfoProvEnt_ *link;
> } InfoProvEnt;

The source positions are approximated in a similar way to the source
positions for DWARF debugging information. They are only approximate but
in our experience provide a good enough hint about where the problem
might be. It is therefore recommended to use this flag in conjunction
with `-g<n>` for more accurate locations.

The lookup table is also emitted into the eventlog when it is available
as it is intended to be used with the `-hi` profiling mode.

Using this flag will significantly increase the size of the resulting
object file but only by a factor of 2-3x in our experience.

This profiling mode creates bands by the address of the info table for
each closure. This provides a much more fine-grained profiling output
than any of the other profiling modes.

The `-hi` profiling mode does not require a profiling build.

This reverts commit 1c7c6f1a.

Ryan Scott authored 4 years ago and Marge Bot committed 4 years ago

As reported in #19432, the rules governing how `DefaultSignatures` are
typechecked became stricter in GHC 9.0 due to simplified subsumption.
However, this was far from obvious to me after reading the User's Guide section
on `DefaultSignatures`. In this patch, I spruce up the documentation in that
section so that it mentions these nuances.

Resolves #19432.

Andreas Klebinger authored 4 years ago and Marge Bot committed 4 years ago

This applies the fix for #19033 to all the other flavours as well.

Sebastian Graf authored 4 years ago and Marge Bot committed 4 years ago

The update of the Outputable instance resulted in a slew of
documentation changes within Notes that used the old syntax.
The most important doc changes are to `Note [Demand notation]`
and the user's guide.

Fixes #19016.

Ben Gamari authored 4 years ago and Marge Bot committed 4 years ago

Previously a255b4e3 failed to update the
non-profiling codepath.

Ben Gamari authored 4 years ago and Marge Bot committed 4 years ago

Previously the profiled flavour transformer failed to add the profiled
ways to the library and RTS ways lists, resulting in link failures.

Sylvain Henry authored 4 years ago and Marge Bot committed 4 years ago

Thanks @mpickering for finding them!

Sylvain Henry authored 4 years ago and Marge Bot committed 4 years ago

Avoid returning a lazy panic value when leak indicators are disabled.

Sylvain Henry authored 4 years ago and Marge Bot committed 4 years ago

($) is INLINE so there is no reason ($!) shouldn't.