Skip to content
Snippets Groups Projects
  1. Aug 23, 2023
    • amesgen's avatar
      users-guide: remove note about fatal Haddock parse failures · a05cdaf0
      amesgen authored and Marge Bot's avatar Marge Bot committed
      a05cdaf0
    • sheaf's avatar
      Compute hints from TcSolverReportMsg · 896e35e5
      sheaf authored and Marge Bot's avatar Marge Bot committed
      This commit changes how hints are handled in conjunction with
      constraint solver report messages.
      
      Instead of storing `[GhcHint]` in the TcRnSolverReport error constructor,
      we compute the hints depending on the underlying TcSolverReportMsg.
      This disentangles the logic and makes it easier to add new hints for
      certain errors.
      896e35e5
    • sheaf's avatar
      Apply shellcheck suggestion to SUBST_TOOLDIR · c82770f5
      sheaf authored and Marge Bot's avatar Marge Bot committed
      c82770f5
    • Matthew Pickering's avatar
      configure: Set WindresCmd directly and removed unused variables · 03fad42e
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      For some reason there was an indirection via the Windres variable before
      setting WindresCmd. That indirection led to #23855.
      
      I then also noticed that these other variables were just not used
      anywhere when trying to work out what the correct condition was for this
      bit of the configure script.
      03fad42e
    • Matthew Pickering's avatar
      hadrian: Remove query' logic to use tooldir · 7cbf9361
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      7cbf9361
    • Matthew Pickering's avatar
      hadrian: Add error when trying to build binary-dist target on windows · d0b48113
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      The binary dist produced by `binary-dist` target doesn't work on windows
      because of the wrapper script the makefile installs. In order to not
      surprise any packagers we just give an error if someone tries to build
      the old binary-dist target rather than the reloc-binary-dist target.
      d0b48113
    • Matthew Pickering's avatar
      ci: Build relocatable bindist on windows · 03474456
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      We now build the relocatable bindist target on windows, which means we
      test and distribute the new method of creating a relocatable bindist.
      03474456
    • Matthew Pickering's avatar
      packaging: Fix installation scripts on windows/RelocatableBuild case · 41cbaf44
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      
      This includes quite a lot of small fixes which fix the installation
      makefile to work on windows properly. This also required fixing the
      RelocatableBuild variable which seemed to have been broken for a long
      while.
      
      Sam helped me a lot writing this patch by providing a windows machine to
      test the changes. Without him it would have taken ages to tweak
      everything.
      
      Co-authored-by: sheaf's avatarsheaf <sam.derbyshire@gmail.com>
      41cbaf44
    • Matthew Pickering's avatar
      hadrian: Add reloc-binary-dist-* targets · fe23629b
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      This adds a command line option to build a "relocatable" bindist.
      
      The bindist is created by first creating a normal bindist and then
      installing it using the `RelocatableBuild=YES` option. This creates a
      bindist without any wrapper scripts pointing to the libdir.
      
      The motivation for this feature is that we want to ship relocatable
      bindists on windows and this method is more uniform than the ad-hoc
      method which lead to bugs such as #23608 and #23476
      
      The relocatable bindist can be built with the "reloc-binary-dist" target
      and supports the same suffixes as the normal "binary-dist" command to
      specify the compression style.
      fe23629b
    • Matthew Pickering's avatar
      Generate build.mk for bindists · 6c043187
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      The config.mk.in script was relying on some variables which were
      supposed to be set by build.mk but therefore never were when used to
      install a bindist.
      
      Specifically
      
      * BUILD_PROF_LIBS to determine whether we had profiled libraries or not
      * DYNAMIC_GHC_PROGRAMS to determine whether we had shared libraries or
        not
      
      Not only were these never set but also not really accurate because you
      could have shared libaries but still statically linked ghc executable.
      
      In addition variables like GhcLibWays were just never used, so those
      have been deleted from the script.
      
      Now instead we generate a build.mk file which just directly specifies
      which RtsWays we have supplied in the bindist and whether we have
      DYNAMIC_GHC_PROGRAMS.
      6c043187
    • Matthew Pickering's avatar
      Abstract windows toolchain setup · 9cac8f11
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      This commit splits up the windows toolchain setup logic into two
      functions.
      
      * FP_INSTALL_WINDOWS_TOOLCHAIN - deals with downloading the toolchain if
        it isn't already downloaded
      * FP_SETUP_WINDOWS_TOOLCHAIN - sets the environment variables to point
        to the correct place
      
      FP_SETUP_WINDOWS_TOOLCHAIN is abstracted from the location of the mingw
      toolchain and also the eventual location where we will install the
      toolchain in the installed bindist.
      
      This is the first step towards #23608
      9cac8f11
    • Matthew Pickering's avatar
      hadrian: Uniformly pass buildOptions to all builders in runBuilder · 0bfa0031
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      In Builder.hs, runBuilderWith mostly ignores the buildOptions in BuildInfo.
      
      This leads to hard to diagnose bugs as any build options you pass with
      runBuilderWithCmdOptions are ignored for many builders.
      
      Solution: Uniformly pass buildOptions to the invocation of cmd.
      
      Fixes #23845
      0bfa0031
    • Ben Gamari's avatar
      base: Don't use Data.ByteString.Internals.memcpy · 6ccd9d65
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      This function is now deprecated from `bytestring`. Use
      `Foreign.Marshal.Utils.copyBytes` instead.
      
      Fixes #23880.
      6ccd9d65
    • sheaf's avatar
      Don't attempt pattern synonym error recovery · e7db36c1
      sheaf authored and Marge Bot's avatar Marge Bot committed
      This commit gets rid of the pattern synonym error recovery mechanism
      (recoverPSB). The rationale is that the fake pattern synonym binding
      that the recovery mechanism introduced could lead to undesirable
      knock-on errors, and it isn't really feasible to conjure up a
      satisfactory binding as pattern synonyms can be used both in expressions
      and patterns.
      See Note [Pattern synonym error recovery] in GHC.Tc.TyCl.PatSyn.
      
      It isn't such a big deal to eagerly fail compilation on a pattern synonym
      that doesn't typecheck anyway.
      
      Fixes #23467
      e7db36c1
  2. Aug 22, 2023
  3. Aug 21, 2023
  4. Aug 17, 2023
  5. Aug 16, 2023
Loading