Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

- We switched to using regex-tdfa, as regex-posix is buggy on Windows.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

New output:

Error:
    Problem with module re-exports:
      - The module 'Asdf'
        is not exported by any suitable package.
        It occurs in neither the 'exposed-modules' of this package,
        nor any of its 'build-depends' dependencies.
    In the stanza 'library'
    In the inplace package 'Reexport2-1.0'

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

kristenk authored 8 years ago and Edward Z. Yang committed 8 years ago

For example, --constraint="any.pkg == 5" applies to "pkg" whether it is a
top-level dependency, setup dependency, or build tool dependency.

I also modified the UserConstraint type so that it is more similar to the
PackageConstraint type, now that both types need to express similar
"constraint scopes".

The executable is unused so it shouldn't need to be built and
cause problems.

Also, convert the test to use the testsuite

Should we stick this in the testing prelude too?

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

The fix is a bit of a hack but it seems to work.

Fixes #4202.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

 - Existing test `InternalLibrary4` was deleted because it relied on the old
   behavior.

 - New tests added are:
    - InternalVersions/BuildDependsBad
    - InternalVersions/BuildDependsExtra
    - InternalVersions/BuildToolsBad
    - InternalVersions/BuildToolsExtra
    - InternalVersions/BuildToolDependsBad
    - InternalVersions/BuildToolDependsExtra
    - ToolDependsInternalMissing

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Edward Z. Yang authored 8 years ago and Edward Z. Yang committed 8 years ago

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

This fixes some "permission denied" failures on Windows,
but it would be a lot better to fix properly.  See the comment
in Test.Cabal.Monad for more details.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Otherwise, ghc-pkg will complain that it's reinitializing the
package database.

Possibly there is some refactor to make withPackageDb more robust
if it is called multiple times.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

TODO: This seems to cause Windows failure

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Previously, clients of runM had to explicitly record and check
the exit code of a run subcommand.  This has now been folded into
runM, so this is done always (which is what you wanted anyway.)

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Previously, in some cases we would carry around an explicit
FilePath for an executable that we wanted to invoke subsequently.

In this new scheme, any executable we want to execute gets registered
to the ProgramDb we are carrying around.  Now we can uniformly
use runProgramM in all cases.  Great!

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>