Draft: try to eliminate all usages of `addFatalError' and substitue with `addError' followed by `return badValue' for a suitable `badValue'

The motivation is that some parsing errors still halt the whole pipeline due to
wrong interaction between the catch mechansim and the layout rule requiring
emission of `error' tokens, So we try to keep as much info in the source up
until the occurrence of error.

Use the new `%error {} {}` resumption facilities with `ValD`, `HsUnboundVar', `WildPat' and `HsWildCardTy' constructors representing parse errors.

Rodrigo Mesquita authored 4 months ago and Marge Bot committed 4 months ago

The 'ModuleGraph' abstraction represents the relationship and strucutre
of the modules being compiled. This structure is meant to be constructed
once at the start of compilation, and never changed again.

However, it's exposed interface was confusing and exposed too many
footguns which led to inneficient usages of the ModuleGraph. This commit
improves significantly the exported interface of ModuleGraph, taking
into consideration the recent improvements around reachability queries.

Since the ModuleGraph graphs and related structures (HPT, EPS) are
performance critical in the sense that somewhat simple mistakes can
cause bad leaks and non-linear memory usage, we want to have proper APIs
that guide efficient usage. This is a good step in that direction.

Rodrigo Mesquita authored 5 months ago and Marge Bot committed 4 months ago

This HasCallStack was a debugging artifact from a previous commit.

Ben Gamari authored 5 months ago and Marge Bot committed 4 months ago

Previously the structure of `mmapInRegion` concealed a subtle bug
concerning handling of `mmap` returning mappings below the beginning of
the desired region. Specifically, we would reset `p = result + bytes`
and then again reset `p = region->start` before looping around for
another iteration. This resulted in an infinite loop on FreeBSD.

Fixes #25492.

sheaf authored 4 months ago and Marge Bot committed 4 months ago

In Hadrian, we are careful to use -/- rather than </>, in order to use
/ instead of \ in filepaths. However, this gets ruined by the use of
makeAbsolute from System.Directory, which, on Windows, changes back
forward slashes to backslashes.

The combination of ScopedTypeVariables + TypeApplications now no longer
enables the use of type applications in constructor patterns, as per
GHC proposal #448.

This completes the deprecation that begun with GHC 9.8.

We also remove the -Wdeprecated-type-abstractions flag, which was
introduced in GHC 9.10.

Ben Gamari authored 4 months ago and Marge Bot committed 4 months ago

GitLab recommends using `https://` to clone submodules and provides the
`GIT_SUBMODULE_FORCE_HTTPS` variable to force this.

Fixes #25528.

Ben Gamari authored 5 months ago and Marge Bot committed 4 months ago

Earlier versions of `directory` are racy on Windows due to #24382.

Also includes necessary Hadrian bootstrap plan bump.

Fixes #24382.

Arnaud Spiwack authored 5 months ago and Marge Bot committed 4 months ago

Fixes #25428

sheaf authored 5 months ago and Marge Bot committed 4 months ago

This change means that the Hadrian multi target will include exactprint.
In particular, this means that HLS will work on exactprint inside the GHC tree.

Ben Gamari authored 4 months ago and Marge Bot committed 4 months ago

These were incorrectly changed by the automated refactoring of the
`ghc-internal` migration.

Fixes #25521.

Ben Gamari authored 5 months ago and Marge Bot committed 4 months ago

Currently the ExecPage facility has two users:

 * GHCi, for constructing info tables, and
 * the adjustor allocation path

Despite neither of these have any spatial locality constraints ExecPage
was using the linker's `mmapAnonForLinker`, which tries hard to ensure
that mappings end up nearby the executable image. This makes adjustor
allocation needlessly subject to fragmentation concerns.

We now instead return less constrained mappings, improving the
robustness of the mechanism.

Addresses #25503.

Ben Gamari authored 5 months ago and Marge Bot committed 4 months ago

We verify that required flags (currently `--output` and `--triple`) are
provided. The implementation is truly awful, but so is getopt.

Begins to address #25500.

Andreas Klebinger authored 10 months ago and Marge Bot committed 4 months ago

When constant folding ensure the result is still within bounds
for the given type by explicitly narrowing the results.

Not doing so results in a lot of spurious assembler warnings
especially when testing primops.

鑫 王 authored 5 months ago and Marge Bot committed 4 months ago

With the Medium code model, the jump range of the generated jump
instruction is larger than that of the Small code model. It's a
temporary fix of the problem descriped in https://gitlab.haskell
.org/ghc/ghc/-/issues/25495. This commit requires that the LLVM
used contains the code of commit 9dd1d451d9719aa91b3bdd59c0c6679
83e1baf05, i.e., version 8.0 and later. Actually we should not
rely on LLVM, so the only way to solve this problem is to implement
the LoongArch backend.

Add new type for codemodel

jeffrey young authored 6 months ago and Marge Bot committed 4 months ago

See this CLC proposal:

- https://github.com/haskell/core-libraries-committee/issues/289

and this CLC proposal for background:

- https://github.com/haskell/core-libraries-committee/issues/288

Metric Decrease:
    MultiLayerModulesTH_OneShot

Cheng Shao authored 4 months ago and Marge Bot committed 4 months ago

This patch bumps macOS minimum SDK version to 11.0 for x86_64-darwin
to align it with aarch64-darwin. This allows us to get rid of the
horrible -Wl,-U,___darwin_check_fd_set_overflow hack, which is causing
linker warnings and testsuite failures on macOS 15. Fixes #25504.

Andreas Klebinger authored 5 months ago and Marge Bot committed 4 months ago

Fixes #24660

Arnaud Spiwack authored 4 months ago and Marge Bot committed 4 months ago

Simply uses the multiplicity as stored in the field. As I'm writing
this commit, the only possible multiplicity is 1, but !13525 is
changing this. It's actually easier to take !13525 into account.

Fixes #25515.

Simon Hengel authored 4 months ago and Marge Bot committed 4 months ago

This is never used for lexing / parsing.  It is only used by
`GHC.Parser.Header.getOptions`.

Cheng Shao authored 4 months ago and Marge Bot committed 4 months ago

This patch makes test-bootstrap related ci jobs only depend on
hadrian-ghc-in-ghci job to finish, consistent with other jobs in the
full-build stage generated by gen_ci.hs. This allows the jobs to be
spawned earlier and improve overall pipeline parallelism.

Cheng Shao authored 5 months ago and Marge Bot committed 4 months ago

This patch makes some minor improvements re nix-in-docker logic in the
ci configuration:

- Update `nixos/nix` to the latest version
- Apply $CPUS to `cores`/`max-jobs` to avoid oversubscribing while
  allowing a reasonable degree of parallelism
- Remove redundant `--extra-experimental-features nix-command` in
  later `nix shell` invocations, it's already configured in
  `/etc/nix/nix.conf`

Andreas Klebinger authored 5 months ago and Marge Bot committed 4 months ago

As #14497 showed black holes can appear inside large objects when
we capture a computation and later blackhole it like we do for AP_STACK
closures.

Fixes #24791

Matthew Pickering authored 6 months ago and Marge Bot committed 4 months ago

The default value for base-unit-id is stored in the settings file.

At install time, this can be set by using the BASE_UNIT_ID environment
variable.

At runtime, the value can be set by `-base-unit-id` flag.

For whether all this is a good idea, see #25382

Fixes #25382

Ben Gamari authored 5 months ago and Marge Bot committed 4 months ago

As noted in #25509, the `-this-package-name` must be passed for each
package to ensure that GHC can response references to the packages'
exposed modules via package-qualified imports. Fix this.

Closes #25509.

Ben Gamari authored 5 months ago and Marge Bot committed 5 months ago

Some testsuite tests require specific tools (e.g. `check-ppr` and
`check-exact`) beyond those shipped in the binary distribution. Skip
these tests.

Fixes #13897.