Skip to content
Snippets Groups Projects
  1. Sep 01, 2023
  2. Aug 31, 2023
  3. Aug 30, 2023
  4. Aug 29, 2023
    • sheaf's avatar
      Export setInertSet from GHC.Tc.Solver.Monad · e542d590
      sheaf authored and Marge Bot's avatar Marge Bot committed
      We used to export getTcSInerts and setTcSInerts from GHC.Tc.Solver.Monad.
      These got renamed to getInertSet/setInertSet in e1590ddc. That commit also removed
      the export of setInertSet, but that function is useful for the GHC API.
      e542d590
    • Ben Gamari's avatar
      21584b12
    • Krzysztof Gogolewski's avatar
      Add a regression test for #23903 · 3054fd6d
      Krzysztof Gogolewski authored and Marge Bot's avatar Marge Bot committed
      The bug has been fixed by commit bad2f8b8.
      3054fd6d
    • Krzysztof Gogolewski's avatar
      Misc cleanup · b60d6576
      Krzysztof Gogolewski authored and Marge Bot's avatar Marge Bot committed
      - Builtin.PrimOps: ReturnsAlg was used only for unboxed tuples.
        Rename to ReturnsTuple.
      - Builtin.Utils: use SDoc for a panic message.
        The comment about <<details unavailable>> was obsoleted by e8d35677.
      - TagCheck: fix wrong logic. It was zipping a list 'args' with its
        version 'args_cmm' after filtering.
      - Core.Type: remove an outdated 1999 comment about unlifted polymorphic types
      - hadrian: remove leftover debugging print
      b60d6576
    • Sylvain Henry's avatar
      ghc-heap: rename C file (fix #23898) · fe9fcf9d
      Sylvain Henry authored and Marge Bot's avatar Marge Bot committed
      fe9fcf9d
    • Vasily Sterekhov's avatar
      Make some evidence uses reachable by toHie · 4f192947
      Vasily Sterekhov authored and Marge Bot's avatar Marge Bot committed
      Resolves #23540, #23120
      
      This adds spans to certain expressions in the typechecker and renamer,
      and lets 'toHie' make use of those spans. Therefore the relevant
      evidence uses for the following syntax will now show up under the
      expected nodes in 'HieAst's:
      
      - Overloaded literals ('IsString', 'Num', 'Fractional')
      
      - Natural patterns and N+k patterns ('Eq', 'Ord', and instances from the
        overloaded literals being matched on)
      
      - Arithmetic sequences ('Enum')
      
      - Monadic bind statements ('Monad')
      
      - Monadic body statements ('Monad', 'Alternative')
      
      - ApplicativeDo ('Applicative', 'Functor')
      
      - Overloaded lists ('IsList')
      
      Also see Note [Source locations for implicit function calls]
      
      In the process of handling overloaded lists I added an extra 'SrcSpan'
      field to 'VAExpansion' - this allows us to more accurately reconstruct
      the locations from the renamer in 'rebuildHsApps'. This also happens to
      fix #23120.
      
      See the additions to Note [Looking through HsExpanded]
      4f192947
    • Vasily Sterekhov's avatar
      Add test for #23120 · 257bb3bd
      Vasily Sterekhov authored and Marge Bot's avatar Marge Bot committed
      257bb3bd
    • Vasily Sterekhov's avatar
      Add test for #23540 · 6bbde581
      Vasily Sterekhov authored and Marge Bot's avatar Marge Bot committed
      `T23540.hs` makes use of `explainEv` from `HieQueries.hs`, so
      `explainEv` has been moved to `TestUtils.hs`.
      6bbde581
    • Greg Steuck's avatar
      Repair `codes` test on OpenBSD by explicitly requesting extended RE · 4f5fb500
      Greg Steuck authored and Marge Bot's avatar Marge Bot committed
      4f5fb500
  5. Aug 28, 2023
    • sheaf's avatar
      .stderr: ScopedTypeVariables =/> TypeAbstractions · fadd5b4d
      sheaf authored
      This commit accepts testsuite changes for the changes in the previous
      commit, which mean that TypeAbstractions is no longer implied by
      ScopedTypeVariables.
      fadd5b4d
    • sheaf's avatar
      Remove ScopedTypeVariables => TypeAbstractions · 9eecdf33
      sheaf authored
      This commit implements [amendment 604](https://github.com/ghc-proposals/ghc-proposals/pull/604/)
      to [GHC proposal 448](https://github.com/ghc-proposals/ghc-proposals/pull/448)
      by removing the implication of language extensions
      
        ScopedTypeVariables => TypeAbstractions
      
      To limit breakage, we now allow type arguments in constructor patterns
      when both ScopedTypeVariables and TypeApplications are enabled, but
      we emit a warning notifying the user that this is deprecated behaviour
      that will go away starting in GHC 9.12.
      
      Fixes #23776
      9eecdf33
    • Zubin's avatar
      testsuite: Add regression test for #23864 · b6903f4d
      Zubin authored and Marge Bot's avatar Marge Bot committed
      Simon says this was fixed by
      
      commit 59202c80
      Author: Sebastian Graf <sebastian.graf@kit.edu>
      Date:   Fri Mar 31 17:35:22 2023 +0200
      
          CorePrep: Eliminate EmptyCase and unsafeEqualityProof in CoreToStg instead
      
          We eliminate EmptyCase by way of `coreToStg (Case e _ _ []) = coreToStg e` now.
          The main reason is that it plays far better in conjunction with eta expansion
          (as we aim to do for arguments in CorePrep, #23083), because we can discard
          any arguments, `(case e of {}) eta == case e of {}`, whereas in `(e |> co) eta`
          it's impossible to discard the argument.
      b6903f4d
    • Zubin's avatar
      testsuite: Add regression test for #23861 · 5248fdf7
      Zubin authored
      Simon says this was fixed by
      
      commit 8d686854
      Author: sheaf <sam.derbyshire@gmail.com>
      Date:   Fri Aug 4 15:28:45 2023 +0200
      
          Remove zonk in tcVTA
  6. Aug 27, 2023
  7. Aug 26, 2023
  8. Aug 25, 2023
  9. Aug 24, 2023
    • Finley McIlwaine's avatar
      Add a test checking overhead of -finfo-table-map · d3e0124c
      Finley McIlwaine authored and Marge Bot's avatar Marge Bot committed
      We want to make sure we don't end up with poor codegen performance resulting from
      -finfo-table-map again as in #23103. This test adds a performance test tracking
      total allocations while compiling ExactPrint with -finfo-table-map.
      d3e0124c
    • Finley McIlwaine's avatar
      Refactor estimation of stack info table provenance · d99c816f
      Finley McIlwaine authored and Marge Bot's avatar Marge Bot committed
      This commit greatly refactors the way we compute estimated provenance for stack
      info tables. Previously, this process was done using an entirely separate traversal
      of the whole Cmm code stream to build the map from info tables to source locations.
      The separate traversal is now fused with the Cmm code generation pipeline in
      GHC.Driver.Main.
      
      This results in very significant code generation speed ups when -finfo-table-map is
      enabled. In testing, this patch reduces code generation times by almost 30% with
      -finfo-table-map and -O0, and 60% with -finfo-table-map and -O1 or -O2 .
      
      Fixes #23103
      d99c816f
    • Antoine Leblanc's avatar
      Be more eager in TyCon boot validity checking · 1420b8cb
      Antoine Leblanc authored and Marge Bot's avatar Marge Bot committed
      This commit performs boot-file consistency checking for TyCons into
      checkValidTyCl. This ensures that we eagerly catch any mismatches,
      which prevents the compiler from seeing these inconsistencies and
      panicking as a result.
      
      See Note [TyCon boot consistency checking] in GHC.Tc.TyCl.
      
      Fixes #16127
      1420b8cb
  10. Aug 23, 2023
Loading